fix: 2 improvements across 3 files#1524
Open
tomaioo wants to merge 3 commits into
Open
Conversation
- Quality: Typo in filename: 'templace-oc-version' should be 'template-oc-version' - Quality: Typo in interface name: 'UnformmatedComponentHistory' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Typo in filename: 'templace-oc-version' should be 'template-oc-version' - Quality: Typo in interface name: 'UnformmatedComponentHistory' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Typo in filename: 'templace-oc-version' should be 'template-oc-version' - Quality: Typo in interface name: 'UnformmatedComponentHistory' Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
ricardo-devis-agullo
requested changes
Jul 25, 2026
ricardo-devis-agullo
left a comment
ricardo-devis-agullo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the cleanup — the intent is good, but the filename rename is incomplete and would break the build if merged as-is.
What works
- Renaming
UnformmatedComponentHistory→UnformattedComponentHistoryinget-components-history.tslooks correct (local type only).
What needs fixing
1. Import not updated
packages/oc/src/registry/domain/validators/index.ts still has:
import templateOcVersionValidator from './templace-oc-version';That is the only importer of this module (call sites go through validateTemplateOcVersion). After the rename it must be:
import templateOcVersionValidator from './template-oc-version';The PR description says imports in index.ts / registry-configuration.ts were updated — they were not. (registry-configuration.ts never imported this file.)
2. Old file should be deleted, not emptied
The diff zeros out templace-oc-version.ts instead of removing it. Prefer a real rename:
git mv packages/oc/src/registry/domain/validators/templace-oc-version.ts packages/oc/src/registry/domain/validators/template-oc-version.ts…then update the import in index.ts.
Checklist before re-review
-
templace-oc-version.tsis gone -
template-oc-version.tshas the previous contents -
validators/index.tsimports./template-oc-version - CI green on 22/24/26
Happy to approve once those are in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: 2 improvements across 3 files
Problem
Severity:
Low| File:packages/oc/src/registry/domain/validators/templace-oc-version.ts:L1The file
templace-oc-version.tscontains a typo ('templace' instead of 'template'). This typo propagates to import paths invalidators/index.tsandvalidators/registry-configuration.ts, reducing code readability and discoverability.Solution
Rename the file to
template-oc-version.tsand update all corresponding import statements across the repository.Changes
packages/oc/src/registry/domain/validators/template-oc-version.ts(new)packages/oc/src/registry/domain/validators/templace-oc-version.ts(modified)packages/oc/src/registry/routes/helpers/get-components-history.ts(modified)